Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hcaptcha usage and provide as a setting #14266

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Fix hcaptcha usage and provide as a setting #14266

merged 1 commit into from
Nov 28, 2023

Conversation

oliverguenther
Copy link
Member

@oliverguenther oliverguenther commented Nov 28, 2023 •
edited
Loading

HCaptcha was only available as an env, but the configuration was not clear. We can provide it as a setting instead to ensure it gets used.

@oliverguenther oliverguenther force-pushed the fix/hcaptcha-configuration branch from a1a74b6 to 2772945 Compare November 28, 2023 15:18
machisuji
machisuji approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@machisuji machisuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@machisuji machisuji merged commit 908c922 into dev Nov 28, 2023
9 checks passed
@machisuji machisuji deleted the fix/hcaptcha-configuration branch November 28, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@machisuji machisuji machisuji approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oliverguenther @machisuji